search

harrisonhjones / phpParticle

PHP Class for interacting with the Spark Cloud (spark.io)
24 stars 6 forks source link

Master #17

Closed devinpearson closed 9 years ago

devinpearson commented 9 years ago

Added device signaling and updated readme

harrisonhjones commented 9 years ago

Couple of comments:

1 - SignalDevice example looks good 2 - uploadFirmware example change is wrong. The true at the end signal a binary firmware file. Tinker.bin is/should be a binary file. We do neet an example for firmware source code uploads but that line change is wrong 3 - The signalDevice function definition has wrong documentation text 4 - Unless I'm wrong we can generate access tokens, we just can't set arbitrary clientIDs yet

Can you fix 2 and 3 and look into 4 and update the pull or issue another?

devinpearson commented 9 years ago

2 - works for me I only changed tinker.bin to tinker.cpp. I tested it before pushing 3 - fixed 4 - not sure how to set this as ive tried all the examples ive been given and whats used in the spark-cli and its not getting set. Im sure I was able to do this a year again

harrisonhjones commented 9 years ago
  1. Oh, I know it works but that's because Spark isn't enforcing the "isBinary" check yet. If they do, in the future for example, it won't work :(
  2. Thanks
  3. I will look into this. Thanks for removing it from the supported functions list.