harrispopgen / mushi

[mu]tation [s]pectrum [h]istory [i]nference
https://harrispopgen.github.io/mushi/
MIT License
24 stars 6 forks source link

duplicate exponent in ridge term #58

Closed wsdewitt closed 4 years ago

wsdewitt commented 4 years ago

The generalized Tikhonov term for demography seems to have retained an exponent 2 from a previous implementation. This is a bug because the matrix product by itself results in squared entries. https://github.com/harrispopgen/mushi/blob/31d71a960a9042fa26a9acd09f1e39ff76b02540/mushi/ksfs.py#L297-L298

kamdh commented 4 years ago

Looks like a bug