search

harry-thorpe / piggy

Pipeline for analysing intergenic regions in bacteria
GNU General Public License v3.0
37 stars 7 forks source link

while(readdir) not consistent amon perl versions #9

Closed EricDeveaud closed 7 years ago

EricDeveaud commented 7 years ago

Hello,

with perl 5.8.9 piggy is broken due to the following code.

while(readdir $dh){
    my $file=$_;

in perl 5.8.9 (pretty old) but it is the one we use on our cluster. $_ is not set in this context.

tested with newer perl > 5.20 and it's OK

attached simple patch sort out the problem sorry to lazy to make a pull request

Eric readdir_loop.patch.txt

harry-thorpe commented 7 years ago

Hi Eric,

Thanks for pointing this out. I have updated the code on all readdir calls. Hopefully it should work now.

Thanks,

Harry

EricDeveaud commented 7 years ago

thanks