search

harryallerston / RPI-Wireless-Hotspot

Configure your Raspberry Pi to act as a WPA encrypted WiFi hotspot, sharing the attatched ethernet connection. Allows the selection from a range of common DNS providers, including unblock-us for netflix. Chromecast support with this feature is also configured.
262 stars 100 forks source link

"length" is misspelled #26

Open tehDrew opened 6 years ago

tehDrew commented 6 years ago

https://github.com/harryallerston/RPI-Wireless-Hotspot/blob/871239247f88fb993a142c3d264c7b6ef84bc224/install#L118

tehDrew commented 6 years ago

Also there should be a space between "at" and "least". Thanks for a useful tool!!!

unixabg commented 6 years ago

Greetings,

On Mon, Nov 27, 2017 at 1:40 PM, Drew Rushmer notifications@github.com wrote:

https://github.com/harryallerston/RPI-Wireless-Hotspot/blob/ 871239247f88fb993a142c3d264c7b6ef84bc224/install#L118

I have addressed this on my fork with https://github.com/unixabg/RPI-Wireless-Hotspot/commit/ac2ccde54aab8005bf2b8f4baa8b5dc23a77d568

I have had some commits that Harry might not want that redirect some info to my fork. I sort of thought our trees were synced, but I appear to be wrong on that.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/harryallerston/RPI-Wireless-Hotspot/issues/26, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_usoS0hzZAcCLh-YPgbk6cDCVJQNUKks5s6xBGgaJpZM4QsLhE .

unixabg commented 6 years ago

Greetings,

On Mon, Nov 27, 2017 at 1:41 PM, Drew Rushmer notifications@github.com wrote:

Also there should be a space between "at" and "least". Thanks for a useful tool!!!

I just corrected this with https://github.com/unixabg/RPI-Wireless-Hotspot/commit/7ead3ac8edc4ac850c23ad126ce62c8df24d774e so if Harry want to pull that he can.

Also thank you for the report. Keep the bugs coming. :) I have also opened up issues on my fork so I can keep track since I have some commits that Harry does not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/harryallerston/RPI-Wireless-Hotspot/issues/26#issuecomment-347302518, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_uslbnBxl56vUPYfft7bQ7qvfMjCeiks5s6xBtgaJpZM4QsLhE .

tehDrew commented 6 years ago

Being pretty darn new to github, I really appreciate the positive feedback, as well as the opportunity to check out your fork of this project. Thanks!

On Mon, Nov 27, 2017 at 4:30 PM, Richard Nelson notifications@github.com wrote:

Greetings,

On Mon, Nov 27, 2017 at 1:41 PM, Drew Rushmer notifications@github.com wrote:

Also there should be a space between "at" and "least". Thanks for a useful tool!!!

I just corrected this with https://github.com/unixabg/RPI-Wireless-Hotspot/commit/ 7ead3ac8edc4ac850c23ad126ce62c8df24d774e so if Harry want to pull that he can.

Also thank you for the report. Keep the bugs coming. :) I have also opened up issues on my fork so I can keep track since I have some commits that Harry does not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/harryallerston/RPI-Wireless-Hotspot/issues/26# issuecomment-347302518, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_ uslbnBxl56vUPYfft7bQ7qvfMjCeiks5s6xBtgaJpZM4QsLhE

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/harryallerston/RPI-Wireless-Hotspot/issues/26#issuecomment-347350634, or mute the thread https://github.com/notifications/unsubscribe-auth/AGTTt_h-eTPi4j1zUYGRigrjhBqvFJvFks5s6zgAgaJpZM4QsLhE .

--

Drew Rushmer drew.rushmer@gmail.com https://medium.com/@drew.rushmer https://www.linkedin.com/in/drewrushmer/ https://www.linkedin.com/in/drewrushmer/