harrydehix / simple-units

expandable unit system, providing unit conversion on small and large scale
MIT License
2 stars 2 forks source link

Mass sg & pl format seems incorrect. Causing issues with generated UoMs. #10

Closed SamGrayson closed 1 month ago

SamGrayson commented 2 months ago

First off, thank you for the awesome library. It's making our UoM conversions much easier.

Just a small issue we've noticed here: https://github.com/harrydehix/simple-units/blob/58ddee457f799c4b202f8bbc14bf7822a017cbf7/src/units/groups/mass.ts#L12-L18

This is causing issues down the line when trying to leverage long names for generated UoMs.

I haven't had a chance yet to check out the other groups.

harrydehix commented 1 month ago

Thank you very much, I'll fix this today!

harrydehix commented 1 month ago

Should be fixed now!