harrydeluxe / php-liquid

A PHP port of Ruby's Liquid Templates
http://www.delacap.com/artikel/Liquid-Templates/
MIT License
239 stars 119 forks source link

Standardize date(), url_decode(), divided_by(), minus(), plus(), times() #43

Closed schmoove closed 7 years ago

schmoove commented 7 years ago

To match the expected behavior of the original Ruby lib:

date() - returns empty value if $input is empty url_decode() - currently missing divided_by(), minus(), plus(), times() - all use floats instead of ints

sanmai commented 7 years ago

You need to rewrite tests to assert against floats.

schmoove commented 7 years ago

Got it - thanks! Forgot to do that