Get 'geospark' ready to be submitted to CRAN

harryprince / geospark

bring sf to spark in production

https://github.com/harryprince/geospark/wiki

57 stars 17 forks source link

Closed javierluraschi closed 5 years ago

javierluraschi commented 5 years ago

Could you merge and submit to CRAN? All tests and checks are passing with this PR.

A few things to notice:

register_gis() no longer required to be explicitly called since we added support in sparklyr to call back to custom initializers, which you do now.
Removed st_join() since with newer versions of dplyr we can use sql_on and standard joins
Polished a bunch of minor things found while running R cmd check --as-cran geo_spark.

javierluraschi commented 5 years ago

Here is the pree-build file ready for CRAN submission: