search

harrysouthworth / gbm

Gradient boosted models
Other
106 stars 27 forks source link

Some C++ changes #6

Closed pdmetcalfe closed 10 years ago

pdmetcalfe commented 10 years ago

I've begun the process of getting the C++ layer sorted. It may well be worth doing before and after tests with these changes; they've been fairly intrusive. Do you have any convenient tests, or is this a forlorn hope. It compiles, anyway. :smile:

This is probably just a start...

harrysouthworth commented 10 years ago

Thanks HUGELY for this.

Regarding tests, there is a very incomplete set of tests in test.gbm.R that can be run using validate.gbm(). It uses the RUnit package. It doesn't appear to produce any graphical output, though that can be fixed fairly easily.

Thanks again!

pdmetcalfe commented 10 years ago

The current plan, insofar as such exists, is to keep pushing it slowly towards something sane, keeping it working all the way. When I've got all the bits in place I may well switch it over towards Rcpp.

If it goes the way I'm expecting there may actually be less code when it's all done.

pdmetcalfe commented 10 years ago

Some damn fool just hit the wrong button... ignore the close and reopen.

harrysouthworth commented 10 years ago

I made some small changes to the test functions, ran them, saved the output. I then pulled, rebuilt, installed and reran. To my eye, the output looks identical.

Ta!