Closed pjambet closed 7 years ago
I suggest merging this and removing the whole unnecessary encryption handling later on.
You're faster than me!
I just created a v1.0 tag https://github.com/harrystech/cronut/tree/v1.0 that we can use as a reference later on when we remove encryption support.
I added a puts
statement for e.message
in main rescue
block, it'll be helpful to see what happened in the logs.
Also added a note to the README and changed the rescue
from Exception
to StandardError
Both routes use the same endpoint, and you could pass ?use_base64=false
to v2/ping
, which I think is fine and doesn't need to be documented since the use_base64 flag is just used internally.
BTW ... don't let my silly comments distract you from merging.
Pings can now be base64 encoded. Simply base 64 encode the public id and pass the
?use_base64=true
query string parameter.This is useful when using RSA encryption and sending a publicly encrypted payload.
Dealing with base64 encoded payload simplifies integration with other platforms (such as the JVM) since we're not relying on some internal ruby byte representation like the default implementation does.