search

harrystech / prelaunchr

A small and simple Rails 4 project that is ready to be used as a prelaunch site. It includes all the necessary requirements like prize groups, open/closed states, and simple social sharing.
MIT License
888 stars 532 forks source link

IP Denial - Allow for front end notification #15

Closed cpres closed 6 years ago

cpres commented 10 years ago

returning a parameter allows to make some notification on the front end. This way people aren't thinking it's a bug: "page just reloads when entering my email", but because they've already added a max # of emails.

danielschwartz commented 10 years ago

Thanks for this -- though I'm not sure a parameter is the best way to surface this. Wouldn't it make sense to surface a flash message with some notification? I would also add some sort of config option (that is set to false by default) that would allow you to enable the notification, that way the feature is available, but not turned on by default.

cpres commented 10 years ago

Thanks for looking at this @danielschwartz - I guess my thought was making this very simple update would allow for people to build off it or not, and make it look more like a known block rather than a potential bug.

danielschwartz commented 10 years ago

I definitely understand the need for this, I just think that adding a param is only doing half the work. Your basically leaving up the messaging to the implementor, which isn't super fair. I would keep this Rails-ey, and implement a flash message, that is disabled by default, but could be enabled with an application config. That way users of Prelaunchr aren't forced to use the feature, but it is available to them if they want it.

werkshy commented 6 years ago

Closing this as dead, apologies.