Open ehsanhaq opened 6 years ago
Merging #221 into master will decrease coverage by
0.04%
. The diff coverage is60%
.
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
- Coverage 90.16% 90.11% -0.05%
==========================================
Files 52 52
Lines 1789 1791 +2
Branches 124 125 +1
==========================================
+ Hits 1613 1614 +1
- Misses 176 177 +1
Impacted Files | Coverage Δ | |
---|---|---|
...in/scala/magellan/mapreduce/ShapeInputFormat.scala | 88.23% <60%> (-2.39%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aa9021e...2587988. Read the comment docs.
@harsha2010 could you review this PR.
In the later version of guava from 15 onwards the constructor method of StopWatch has been deprecated, and throws following exception.
java.lang.IllegalAccessError: tried to access method com.google.common.base.Stopwatch.()V from class magellan.mapreduce.ShapeInputFormat
at magellan.mapreduce.ShapeInputFormat.computeSplits(ShapeInputFormat.scala:50)
at magellan.mapreduce.ShapeInputFormat.getSplits(ShapeInputFormat.scala:43)
at org.apache.spark.rdd.NewHadoopRDD.getPartitions(NewHadoopRDD.scala:125)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:252)
at org.apache.spark.rdd.RDD$$anonfun$partitions$2.apply(RDD.scala:250)
at scala.Option.getOrElse(Option.scala:121)
This make it impossible to use magellan where it is required to have a later version of guava 15+
To solve this we could either use System.getTime or apache commons-lang3 which also provides a StopWatch class. This PR uses commons-lang3 StopWatch to elevate the dependency on guava.