search

harshangrjn / QuantumCircuitOpt.jl

A Julia/JuMP Package for Optimal Quantum Circuit Design
Other
56 stars 15 forks source link

CV Enabled for 3 qubits and Added Gates #12

Closed lockwo closed 3 years ago

lockwo commented 3 years ago

Added CVDagger Gate and Support for CVDagger and CV for 3 qubit systems. Added CVDagger gate to docs.

codecov[bot] commented 3 years ago

Codecov Report

Merging #12 (ff6f3b3) into master (fe8ee59) will increase coverage by 0.23%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   92.44%   92.67%   +0.23%     
==========================================
  Files          12       12              
  Lines        1178     1215      +37     
==========================================
+ Hits         1089     1126      +37     
  Misses         89       89
Impacted Files Coverage Δ
src/data.jl 94.19% <100.00%> (+0.56%) :arrow_up:
src/gates.jl 88.00% <100.00%> (+0.50%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe8ee59...ff6f3b3. Read the comment docs.

harshangrjn commented 3 years ago

Thanks @lockwo ! Can you also add a few tests to this file for these new gates to bring the coverage back up to ~92-93%? You can test the products against the QCO.ToffoliGate()?

lockwo commented 3 years ago

I added a toffoli test and an identity check, what other test types should be added?

harshangrjn commented 3 years ago

@lockwo In here, you can see a few gates (like CV_12 and others) are not covered by tests (codecov results). Could you add a few more tests, like verifying these new gates as a decomposition using H, T and CNOT gates?

lockwo commented 3 years ago

Alright, fixed everything up so all the tests pass