harshi0102 / ruby-capstone

Ruby Capstone Project is an app that will have the option to record what books, games, and music albums are in our library and includes labels, authors and genres
MIT License
0 stars 0 forks source link

Ruby Capstone Project #5

Open harshi0102 opened 1 year ago

harshi0102 commented 1 year ago

Hi,

This is the Kanban board for the Microverse Ruby capstone project.

Our team is composed of 2 people ,Harshika @harshi0102 and Earnest @ernestkorir

Team member 1 : @harshi0102 (Harshika) Team member 2: @ernestkorir (Earnest)

Below is the Project link: https://github.com/harshi0102/ruby-capstone/projects/1

Unfortunately, my second team member was not able to collaborate with me properly, so Student success team of Microverse made me solo this week.

image

Student Success has given me permission to continue the week solo. If you have any questions please reach out to Marco via the Code Reviewers Slack workspace.

image

VICTOR-CHUKWU commented 1 year ago

Hi @harshi0102 and @ernestkorir ๐Ÿ‘‹

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

almost

Required Changes โ™ป๏ธ

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ibizugbe commented 1 year ago

Hi @VICTOR-CHUKWU @harshi0102 ๐Ÿ‘‹๐Ÿ‘‹๐Ÿ‘‹,

tryagain

Great work on making the changes requested by a previous reviewer ๐Ÿ‘ You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlightsโœ…โœ…

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

ichala commented 1 year ago

Hi Team,

Status: Approved :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:

68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f6c3366516333614356304871707a5763552f67697068792e676966

To Highlight ๐Ÿ’ช๐Ÿป

Optional Suggestions :


Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag ichala in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.