Open harshi0102 opened 1 year ago
Hi @harshi0102 and @ernestkorir ๐
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
correct
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi @VICTOR-CHUKWU @harshi0102 ๐๐๐,
Great work on making the changes requested by a previous reviewer ๐ You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
[x] Descriptions and poinrts has been added to each cards๐.
[x] Cards are assigned to each members๐.
[ ] Just as the previous reviewer suggested, this is a big project and I think it can be broken into several tasks to make the milestones or work process more detailed. Hence, having just four cards is not enough for this project๐. Kindly do well to add more tasks to the project and also add some group task as the previous reviewer has requested๐.
[ ] I noticed the points are not evenly destributed amongst team mates which is unfair๐ฅฒ. I can see that a majority of the task has been assigned to one person. Kindly do well to ensure the points/ workload are equally distributed among the members of the team๐.
Check the comments under the review.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi Team,
Kanban is ready, good luck โ๏ธ
Good job implementing the requirements :+1: Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! ๐
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag ichala in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi,
This is the Kanban board for the Microverse Ruby capstone project.
Our team is composed of 2 people ,Harshika @harshi0102 and Earnest @ernestkorir
Team member 1 : @harshi0102 (Harshika) Team member 2: @ernestkorir (Earnest)
Below is the Project link: https://github.com/harshi0102/ruby-capstone/projects/1
Unfortunately, my second team member was not able to collaborate with me properly, so Student success team of Microverse made me solo this week.
Student Success has given me permission to continue the week solo. If you have any questions please reach out to Marco via the Code Reviewers Slack workspace.