harshit1142 / BookStore

A Collections of Books ,with add to favorite feature.
https://bookstore-ochre-psi.vercel.app/
MIT License
16 stars 18 forks source link

Feature request: To add cover image of books on the home page #24

Closed Prathamesh0901 closed 1 month ago

Prathamesh0901 commented 1 month ago

Google api does provide the image link of the book's cover. If we showcase that on the homepage alongside the books information it would be great for the users. I have already worked on this kind of feature, just that I used different api. Take a look: https://book-management-bay.vercel.app/books image

So, I would love to contribute in this project and would love to add this feature!

harshit1142 commented 1 month ago

@Prathamesh0901 Sure, you can add this . But there is also a section for "Contributed Books" so add a static image URL as it is for good-first-issue. ( Modify bookstore.js)

Do add Screenshots in your PR.

Do star ⭐ the repo and follow me to start.

harshit1142 commented 1 month ago

@Prathamesh0901 don't modify the current page. Instead, add a button for Google books and add a new page there showing books . Got ?

Prathamesh0901 commented 1 month ago

No I don't get it. Please elaborate.

harshit1142 commented 1 month ago

@Prathamesh0901 so, you are going to add a new API ,if I am not wrong.

Prathamesh0901 commented 1 month ago

I actually thought you were fetching all the books from google api which are on the homepage. But now i noticed that these books have hardcode. No worries I will add the links to the cover image in bookstore.js which will use openlibray's api.

harshit1142 commented 1 month ago

@Prathamesh0901 few are hardcode, rest are using googleapis. So, if it contains image URL add it .

Prathamesh0901 commented 1 month ago

image is this ok? @harshit1142

harshit1142 commented 1 month ago

@Prathamesh0901 make it look like a card.

Prathamesh0901 commented 1 month ago

image @harshit1142 ?

harshit1142 commented 1 month ago

@Prathamesh0901 Make a PR