harshjohar / fabchat

Fabchat is a VoIP and instant messaging social platform. Create servers, create channels, talk on voice chat/real time messaging. have fun :)
https://fabchat.vercel.app/
5 stars 9 forks source link

Server list glitch #32

Open harshjohar opened 1 year ago

harshjohar commented 1 year ago

The following glitch is there when server is exited or entered(see the left most bar). It should be static and don't go away when server I changed.

https://user-images.githubusercontent.com/50266759/216943657-b2a6e0f1-f433-4cef-a165-c98d9d0dd088.mov

ugpec79 commented 1 year ago

Sir pls assign it to me

ken1000minus7 commented 1 year ago

@harshjohar from what I can see, this is happening on switching from any server to dms and vice versa cuz PageLayout is being re rendered and so fetching of servers is done again. Maybe we can wrap each page inside PageLayout in app.tsx instead, based on their route. Any better method? 🤔

harshjohar commented 1 year ago

I suggested to put servers into redux so that we dont have to fetch it on every render, this way glitch wont happen maybe 🤔

ken1000minus7 commented 1 year ago

Yeah can try that, gibme I'll try