harshmangalam / hydrogen-solidjs-client

A social media web app powered by SolidJS
GNU General Public License v3.0
77 stars 54 forks source link

Added tooltip to "delete icon", "post privacy icon", "like icon button" and "comment icon button" #22

Closed somenath203 closed 1 year ago

somenath203 commented 1 year ago

I have successfully added tooltip "delete icon", "post privacy icon", "like icon button" and "comment icon button" to Hydrogen.js frontend as a part of Hacktoberfest 2022.

Screenshot (153)

Screenshot (154)

Screenshot (155)

Screenshot (156)

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @harshmangalam on Vercel.

@harshmangalam first needs to authorize it.

somenath203 commented 1 year ago

Please use tailwindcss classes to add tooltips. You can create reusable Tooltip component for icon button.

I actually don't know talwindcss. That's why I used normal CSS to create the tooltips.

somenath203 commented 1 year ago

I have uploaded the screenshots of the tooltips. You can check it here https://github.com/harshmangalam/hydrogen-solidjs-client/pull/22#issue-1393382989

harshmangalam commented 1 year ago

That is looking nice. Is it compatable with dark mode ?

somenath203 commented 1 year ago

Wait. Give me some minute. I am posting the pictures of the tooltips with the dark mode

somenath203 commented 1 year ago

Here are the tooltips in dark mode

Screenshot (157)

Screenshot (158)

Screenshot (159)

Screenshot (160)

somenath203 commented 1 year ago

Is this OK https://github.com/harshmangalam/hydrogen-solidjs-client/pull/22#issuecomment-1264537733 ??

harshmangalam commented 1 year ago

Okay looking nice will review your code.

somenath203 commented 1 year ago

Ok

harshmangalam commented 1 year ago

Home page is breaking on mobile device

somenath203 commented 1 year ago

Is this responsiveness ok??

Can I push this code??

Screenshot (161)

somenath203 commented 1 year ago

Is the home page OK with the responsiveness of the tooltips https://github.com/harshmangalam/hydrogen-solidjs-client/pull/22#issuecomment-1264581812 ??

somenath203 commented 1 year ago

Since you are not replying, I have created a pull request regarding the mobile responsiveness of the tooltip.

I would like to request you to kindly check if everything os working fine or not.

Thank You.