harshmangalam / hydrogen-solidjs-client

A social media web app powered by SolidJS
GNU General Public License v3.0
78 stars 54 forks source link

Better Password Validation #64

Closed Ririio closed 1 year ago

Ririio commented 1 year ago

I noticed you're not validating your password. Creating an account with a password of "123" works, but it doesn't sound secure. I suggest adding a validation that prevents the creation of an account if a password:

This ensures that it would be difficult for other people to access another user's account easily

I would like to work on this if possible

harshmangalam commented 1 year ago

Great idea i am assigning this task to you.

Ririio commented 1 year ago

Here's what I came up with in terms of how it would look like, tell me if you think there's any that needs changing

Missing Uppercase image

Missing Number image

harshmangalam commented 1 year ago

Awesome much more improved password security than before

harshmangalam commented 1 year ago

Added by @Ririio

Ririio commented 1 year ago

I noticed a problem when re-checking my code. It seems that it doesn't validate the length of the password. So for example I have a password "A1", it is still valid even though I specified that it should only be when the length is also equal or greater than 12.

I'm sending a pull request to fix this issue if you mind updating it

Uppercase Validation image Numerical Validation image Length Validation image