search

harshq / react-native-mentions

Mentions textbox for React Native. Works on both ios and android. :whale:
MIT License
309 stars 82 forks source link

[Question] View style removed ? #18

Open pi-chan opened 6 years ago

pi-chan commented 6 years ago

@harshq I noticed that the new version of this package not support props for root view style, implemented in my PR #10.

ref https://github.com/harshq/react-native-mentions/commit/7c7098117c3830c10e848257c7b799fc545608a3#diff-a8eb8d969b80431379d772201132a07fR100

Is there some reason?

harshq commented 6 years ago

This is purely by an accident. But not what we can do with a prop like this. Would you mind sharing a usecase ?

pi-chan commented 6 years ago

hmmm, it is a little bit difficult to describe. please see this image,

capture

I want to expand blue View to fill MentionsTextInput (parent view) by adding flex: 1

Both textInputMinHeight and textInputMaxHeight, cannot affect as I expected.

pribeh commented 6 years ago

Flex doesn't seem to work. I'm using alignSelf:'stretch' for width for now. I'm not sure what has been done to the textinput but there's no way of applying flex properly to it.