hartenthaler / hh_extended_family

webtrees - showing the extended family of an individual (like cousins and uncles, aunts, ...)
GNU General Public License v3.0
23 stars 9 forks source link

Request: use subject's full name instead of nickname #33

Closed reteP-riS closed 3 years ago

reteP-riS commented 3 years ago

This is a nice module. Thank you, Hermann!

I nevertheless have a request. The extended family tab for an Edward Todd LASTNAME says "Toddy has 1 grandfather and 1 grandmother recorded (2 in total)." While this is factually correct I'd prefer to see his full name instead of his nickname Toddy.

hartenthaler commented 3 years ago

This is a tab, so you can see his full name at the top of the screen. The main idea of this module is to concentrate on the members of the extended family. When I saw the full name of the proband 9 times repeated, my opinion was to use a nice short name like the nickname or the Rufname or the first of the given names instead of the full name in order to show the name, but have it less dominant.

Maybe I will allow the admin to choose what he likes.

jpretired commented 3 years ago

If I may I agree with @hartenthaler, i.e. not full name. But there is a tiny bug: if there is a Name prefix it is shown as a name:

image

reteP-riS commented 3 years ago

Thanks for taking care. I understand the motivation, but at least in my data the nicknames are often from the subject's childhood and sound a bit funny or even inappropriate, especially when mentioned so often on a single page. In my example I have

1 NAME Edward Todd* LASTNAME
2 NICK Toddy

Maybe use something like "Edward Todd has ..." with Todd underlined or "Todd has ..." or simply remove these summary lines which only repeat what we already see in the tables with the respective colors and numbers.

hartenthaler commented 3 years ago

@jpretiered: yes this is a bug that has to be fixed.

@reteP-riS: ok, in the first step I will prefer Rufname as the highest priority instead of nickname; and I'm thinking about making this an option.

hartenthaler commented 3 years ago
reteP-riS commented 3 years ago

This is an excellent solution, Hermann. Thank you!

hartenthaler commented 3 years ago

done in release 2.0.16.23