search

hartenthaler / hh_extended_family

webtrees - showing the extended family of an individual (like cousins and uncles, aunts, ...)
GNU General Public License v3.0
23 stars 9 forks source link

2.0.16.31 - Partner section: a correct and incorrect summary if probands partner has/had a partner #56

Closed TheDutchJewel closed 3 years ago

TheDutchJewel commented 3 years ago

For a proband whose partner has/had a partner, two summaries appear:

  1. a correct statement of the number of partners and partners of partners
  2. an incorrect one in which the partner of the partner is stated as the partner of the proband

afbeelding

hartenthaler commented 3 years ago

Thank you for your comment. Concluding from that you do not comment on the grouping of the partners, I assume that this is now fine for you.

For me, both statements are correct, because for me "partner" includes direct partners and partners of partners. I plan to combine both statements to one statement: "xxx has two female partners and 1 male partner of partners.", but yesterday it was too late to program this.

reteP-riS commented 3 years ago

I usually urge to make design decisions instead of implementing too many options, but in this specific case I am not convinced that the partner's partner should be shown at all and I'd therefore like to ask whether this can be implemented with an on/off switch in the admin area.

hartenthaler commented 3 years ago

Now the statement combines information about partner versus partner of partners and male versus female.

Partners of partners are shown in the webtrees standard "information bar", too. So why should they be hidden in the extended family module? For me, they are members of the extended family.