search

hartkopp / can-isotp

Linux Kernel Module for ISO 15765-2:2016 CAN transport protocol PLEASE NOTE: This module is part of the mainline Linux kernel since version 5.10
Other
239 stars 69 forks source link

fix issue #42 by returning -ECOMM on FC timeout on tx path #43

Closed Sauci closed 2 years ago

Sauci commented 3 years ago

This PR proposes a way to return -ECOMM when no Flow Control frame is received on time after transmission of the First Frame

Sauci commented 3 years ago

For info, this patch has been tested on a Raspberry Pi with a custom kernel including the changes.

uname -a
Linux raspberrypi 5.11.10-v7l+ #5 SMP Thu Apr 1 10:25:26 BST 2021 armv7l GNU/Linux

I'm not sure how the -ECOMM error here is reported to the userspace.

Sauci commented 3 years ago

@hartkopp would it be an implementation of this bug? I guess this pull request might also correct the behavior described here. Let me know if I should modify the implementation, and I will update the pull request accordingly.

Thomseeen commented 3 years ago

Hey Sauci, with this modul beeing part of the mainline kernel, you might get a quicker reaction by moving this to the kernel maillist at linux-can@vger.kernel.org :)

marckleinebudde commented 3 years ago

I've moved the discussion and review to the linux-can ML: https://lore.kernel.org/linux-can/20210428091224.lsqf4tttd7uijdms@pengutronix.de

hartkopp commented 2 years ago

Added in mainline and here in out-of-tree repo. Thx!