search

harttle / liquidjs

A simple, expressive, safe and Shopify compatible template engine in pure JavaScript.
https://liquidjs.com
MIT License
1.5k stars 237 forks source link

chore: adjust typings dir #664

Closed fupengl closed 7 months ago

fupengl commented 7 months ago

Adjust the compatible typing file path to keep it consistent with historical versions.

Now

import { Tag } from 'liquidjs/dist/src/tags/assign'

Old

import { Tag } from 'liquidjs/dist/tags/assign'
harttle commented 7 months ago

Do we have real world scenarios where it's broken from some version? So we can change this patch from a chore to a fix. Otherwise we will not release the change until next fix or feature.

I think this change is good to have to reduce unnecessary hierarchy. Thanks for the change.

harttle commented 7 months ago

@all-contributors please add @fupengl for code.

allcontributors[bot] commented 7 months ago

@harttle

I've put up a pull request to add @fupengl! :tada:

fupengl commented 7 months ago

Do we have real world scenarios where it's broken from some version? So we can change this patch from a chore to a fix. Otherwise we will not release the change until next fix or feature.

I think this change is good to have to reduce unnecessary hierarchy. Thanks for the change.

The version I used before was 10.6.1. After upgrading to the latest version, an error occurred in the ts type.

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 10.10.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: