search

harttle / liquidjs

A simple, expressive, safe and Shopify compatible template engine in pure JavaScript.
https://liquidjs.com
MIT License
1.5k stars 237 forks source link

fix: allow liquidMethodMissing to return any supported value type #698

Closed admtnnr closed 3 months ago

admtnnr commented 3 months ago

The issue is that the type of liquidMethodMissing is too restrictive and only allows returning string rather than any supported value type. I ran into this issue when trying to return a Drop from liquidMethodMissing to enable dynamic lookups along an entire accessor chain.

admtnnr commented 3 months ago

@harttle I think I addressed your single piece of feedback, let me know if there's anything else you'd like changed!

harttle commented 3 months ago

@all-contributors please add @admtnnr for code

allcontributors[bot] commented 3 months ago

@harttle

I've put up a pull request to add @admtnnr! :tada:

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 10.13.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: