search

harttle / liquidjs

A simple, expressive, safe and Shopify compatible template engine in pure JavaScript.
https://liquidjs.com
MIT License
1.5k stars 237 forks source link

fix: isComparable full interface check #701

Closed GuillermoCasalCaro closed 3 months ago

GuillermoCasalCaro commented 3 months ago

Summary

This pull request enhances the isComparable function to ensure it fully implements the Comparable interface, which includes the methods equals, gt, geq, lt, and leq.

Enhancement of isComparable Function

The isComparable function has been improved to check for the complete implementation of the Comparable interface. This ensures that the function correctly identifies objects that are meant to be compared using the methods of the Comparable interface.

Related Issues

Fixes #700

harttle commented 3 months ago

@all-contributors please add @GuillermoCasalCaro for code

allcontributors[bot] commented 3 months ago

@harttle

I've put up a pull request to add @GuillermoCasalCaro! :tada:

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 10.13.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: