hartwigmedical / hmftools

Various algorithms for analysing genomics data
GNU General Public License v3.0
187 stars 58 forks source link

Dev 2919: PEACH JAVA review #358

Closed DFKoetsier closed 3 months ago

DFKoetsier commented 1 year ago

Hi Paul,

As you asked, I have created a pull request to make the code review more efficient. This code is not yet ready to be merged.

Thanks for taking a look at it! David

DFKoetsier commented 3 months ago

Hi David, had a look at the changes to Orange and Orange-datamodel and they look fine to me and seem to match the description you provided.

One tiny possible loose end is that there is a test file in orange test_run/peach, I assume it could be renamed to the new extension. Though this could also be done when support for the old peach is removed.

Great, thanks! I plan to change this once I have put Java Peach into the pipeline.