hartwigmedical / hmftools

Various algorithms for analysing genomics data
GNU General Public License v3.0
181 stars 56 forks source link

Fix orange datamodel artifact #384

Closed mvanniekerkHartwig closed 1 year ago

mvanniekerkHartwig commented 1 year ago

Small update to the orange datamodel build process. The previous one was flawed because the orange datamodel pom depends on the parent pom, but the parent pom was not present in artifact registry.

I fixed this by deploying the parent pom first with the version set to the tag that triggers the build. In practice that means the version of the parent pom will always conform to ^orange-datamodel-.*$. Deploying the parent pom required adding artifact-registry to the distributionManagement of the parent. I tested this and for building the hmftools project still no gcloud configuration is required on your local machine, so users without gcloud can still build the project.