do not fail when a relation cannot be created - Githubissues

haru / redmine_code_review

70 stars 29 forks source link

do not fail when a relation cannot be created #10

Open jkraemer opened 6 years ago

jkraemer commented 6 years ago

This can easily happen e.g. if it would create a circular dependency, and in this case, the user is left with a review he cannot save, without an error message. I think it is better to silently not create the relation in this case.

coveralls commented 6 years ago

Coverage remained the same at 87.747% when pulling 93ad014257b4cfdb3854b83569c3f86cbefa1682 on planio-gmbh:safer-relation-creation into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage remained the same at 87.747% when pulling 93ad014257b4cfdb3854b83569c3f86cbefa1682 on planio-gmbh:safer-relation-creation into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage remained the same at 87.747% when pulling 93ad014257b4cfdb3854b83569c3f86cbefa1682 on planio-gmbh:safer-relation-creation into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage remained the same at 87.747% when pulling 93ad014257b4cfdb3854b83569c3f86cbefa1682 on planio-gmbh:safer-relation-creation into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage remained the same at 87.747% when pulling 93ad014257b4cfdb3854b83569c3f86cbefa1682 on planio-gmbh:safer-relation-creation into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage remained the same at 87.747% when pulling 93ad014257b4cfdb3854b83569c3f86cbefa1682 on planio-gmbh:safer-relation-creation into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.