search

haru / redmine_code_review

70 stars 29 forks source link

code review dosen't work with redmine_banner #19

Closed hiroshi24da closed 4 years ago

hiroshi24da commented 4 years ago

Hello.

I tried code review on redmine 4.1.0, and couldn't write review because pencil icons don't appear when installed with banner. It works without banner.

redmine 4.1.0 redmine_code_review 1.0.0 redmine_banner 0.3.0

haru commented 4 years ago

I tried to reproduce with as same as your environment: redmine 4.1.0, code_review 1.0.0, banner 0.3.0. But I can't be reproduced. Pencil icons were appeared.

image

Does any javascript error appear in your browser's developer console?

hiroshi24da commented 4 years ago

Sorry, it depends on browser. It works on chrome, but doesn't on firefox.

hiroshi24da commented 4 years ago

And it works on both chrome and firefox on redmine3.4.4, code_review0.9.0, banner0.1.2

haru commented 4 years ago

Hmm. It works fine with my firefox. Can you try clear cache?

hiroshi24da commented 4 years ago

Cash clear don't work... It seems that there are banner related javascript errors, but there's no code review related error. javascript_error

haru commented 4 years ago

Does following file exist in your Redmine installation directory? public/plugin_assets/redmine_banner/javascripts/banner.js

hiroshi24da commented 4 years ago

banner.js exists. and... resolved !

(1) redmine4.1.0 + code review + banner + firefox > works (2) redmine4.1.0 + code review + banner + firefox + AdBlock > doesn't work

I wonder why (2) works on redmine3.4.4. Anyway it works. Thanks for your help and great plugin.

akiko-pusu commented 4 years ago

@haru Thanks for your support!