haru / redmine_code_review

70 stars 29 forks source link

Internal error #21

Open HereInMyOwnSkin opened 4 years ago

HereInMyOwnSkin commented 4 years ago

Environment: Redmine version 4.1.1.stable Ruby version 2.6.6-p146 (2020-03-31) [x64-mingw32] Rails version 5.2.4.2 Environment production Database adapter PostgreSQL Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery smtp SCM: Subversion 1.13.0 Filesystem
Redmine plugins: redmine_agile 1.5.3 redmine_checklists 3.1.16 redmine_cms 1.2.1 redmine_code_review 1.0.0 redmine_contacts 4.3.0 redmine_contacts_helpdesk 4.1.8 redmine_contacts_invoices 4.2.3 redmine_crm_mailchimp 1.0.4 redmine_favorite_projects 2.1.0 redmine_finance 2.1.7 redmine_people 1.5.1 redmine_products 2.1.2 redmine_questions 1.0.2 redmine_reporter 1.0.3 redmine_resources 1.0.2 redmine_zenedit 1.0.3 redmineup_tags 2.0.8

Had the following issue in the log: Started GET "/projects/migratevms2020/settings" for 10.69.165.14 at 2020-06-22 14:11:29 +0100 Processing by ProjectsController#settings as HTML Parameters: {"id"=>"migratevms2020"} Current user: admin (id=1) Rendering projects/settings.html.erb within layouts/base Rendered projects/settings.html.erb within layouts/base (1295.2ms) Completed 500 Internal Server Error in 1353ms (ActiveRecord: 31.5ms)

ActionView::Template::Error (super: no superclass method `project_settings_tabs' for #<#:0x0000000013c94d58> Did you mean? project_settings_tabs_with_agile): 1:

<%=l(:label_settings)%>

2: 3: <%= render_tabs project_settings_tabs %> 4: 5: <% html_title(l(:label_settings)) -%>

plugins/redmine_code_review/lib/code_review_projects_helper_patch.rb:22:in project_settings_tabs' plugins/redmine_finance/lib/redmine_finance/patches/projects_helper_patch.rb:38:inproject_settings_tabs_with_finance' app/views/projects/settings.html.erb:3:in _app_views_projects_settings_html_erb__315216044_165980740' lib/redmine/sudo_mode.rb:65:insudo_mode'

I fixed it by changing the following: I modified "C:\Redmine\plugins\redmine_code_review\lib\code_review_projects_helper_patch.rb" so that the method name was changed from: def project_settings_tabs to def code_review_project_settings_tabs

this fixed the issue.