haru / redmine_code_review

70 stars 29 forks source link

“.” path problem #22

Open ynp opened 4 years ago

ynp commented 4 years ago

redmine 4.1.1 4.0.4 If there is a problem with the path, click "difference" to go in, directly click the "pencil" button, and add a task, then there will be problems with the path, and it will become ".", as shown in the figure, causing the problem that the code cannot be directly located. Please guide https://raw.githubusercontent.com/ynp/mytest/master/1111.png https://raw.githubusercontent.com/ynp/mytest/master/2222.png

k-na-g commented 4 years ago

redmine 4.1.1 4.0.4 3.4.6 I have a similar event. Occurs only when reviewing from revision differences. The path was set correctly when reviewing from the differences of each file in the revision.

ynp commented 3 years ago

redmine 4.1.1 4.0.4 3.4.6 I have a similar event. Occurs only when reviewing from revision differences. The path was set correctly when reviewing from the differences of each file in the revision.

Version 3.4.6 shows ".", but click to enter the relevant review interface. If 4. X does not work, an error is reported directly.

freefloatingplanet commented 3 years ago

I had a similar situation (Redmine 4.1.0) and resolved it. When I clicked "difference", I found the page style was broken. In this case, the url was http://xxxx/[PathToFile]. Then I switched "view difference" and the page style was fixed but the url has no filepath. In this case, I added a task and found "." path problem. I guess this problem came through viewing a javascript file. I found a solution of the broken style here, https://www.redmine.org/issues/32449. I apply this solution, then the broken style is fixed and the new task added can include a correct filepath. Above Defect #32449 is fixed in Redmine 4.1.1 and 4.0.7, so different from your case. But I hope it helps.