haru / redmine_code_review

70 stars 29 forks source link

Remove alias method chain and deprecated assertions #7

Open jkraemer opened 6 years ago

jkraemer commented 6 years ago

Redmine 4 will upgrade to Rails 5, where alias_method_chain is not available anymore. This PR (based on current master) replaces it with prepend / a call to super. Also I replaced deprecated assert_tag assertions with assert_select.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.06%) to 87.686% when pulling ac73eb617fca95a794a97ada62000b0129a6ab08 on planio-gmbh:remove-alias-method-chain into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.