More refactoring - Githubissues

haru / redmine_code_review

70 stars 29 forks source link

More refactoring #9

Open jkraemer opened 6 years ago

jkraemer commented 6 years ago

Few refactorings in controllers / models. Likely I'll be adding more here soon.

There is no point in using unloadable in Redmine plugins nowadays.
require_dependency should only be used when necessary
made few parts of the code more Ruby-like and thus more readable (imho)

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.

coveralls commented 6 years ago

Coverage decreased (-0.1%) to 87.619% when pulling fecd3d0c5def0c27e4adc8218b5fb835f2291e2a on planio-gmbh:more-refactoring into 61f3a3443e8862de22bfbdc46069f596ec72ebce on haru:master.