search

haru / redmine_wiki_extensions

57 stars 30 forks source link

Stack level too deep #12

Open phlegx opened 5 years ago

phlegx commented 5 years ago

Hi @haru!

We are still using redmine version 3.3.2 (Docker image redmine:3.3.2) with your redmine_wiki_extension version 0.7.0.

We have recently re-build and re-deployed this same image we had already runnig but now facing this error when we go to a projects wiki page:

Processing by WikiController#show as HTML
  Parameters: {"project_id"=>"admin-server"}
  Current user: user@example.com.com (id=6)
Completed 500 Internal Server Error in 98ms (ActiveRecord: 46.9ms)

SystemStackError (stack level too deep):
  plugins/redmine_wiki_extensions/lib/wiki_extensions_wiki_controller_patch.rb:51:in `render_with_wiki_extensions'
  plugins/redmine_wiki_extensions/lib/wiki_extensions_wiki_controller_patch.rb:62:in `respond_to_with_wiki_extensions'
  app/controllers/wiki_controller.rb:116:in `show'
  lib/redmine/sudo_mode.rb:63:in `sudo_mode'

Do you perhaps have an idea what suddenly might causing this?

phlegx commented 5 years ago

What I have added to the Redmine Docker image is only this line:

RUN printf "deb http://archive.debian.org/debian/ jessie main\ndeb-src http://archive.debian.org/debian/ jessie main\ndeb http://security.debian.org jessie/updates main\ndeb-src http://security.debian.org jessie/updates main" > /etc/apt/sources.list

Since Debian Jessie was archived, see: https://superuser.com/a/1423685

rroseselavy42 commented 5 years ago

I'm just curious here, how does adding jessie sources fix the issue?

rroseselavy42 commented 5 years ago

doing some troubleshooting it looks like it has something to do with how this plugin interacts with the Additionals plugin seems to be causing problems.

phlegx commented 5 years ago

Hi @rroseselavy42! Thanks for having a look into this! Have you been able to find out out something already?

I'm just curious here, how does adding jessie sources fix the issue?

Actually adding these solves the problem that Debian Jessie was archived and has differenet package source URI's now. Not all but some and therefor I was not able to install additonal apt packages in the this docker image. The Docker image redmine 3.3.2 was build some time ago and it most likely has an older Jessie version with the old Jessie package URI's.

In the meanwhile I found an easier fix. Simply adding this to my Dockerfile at the beginning solves the issue:

RUN sed -i '/jessie-updates/d' /etc/apt/sources.list