search

haru / redmine_wiki_extensions

58 stars 30 forks source link

Use div macros for header/footer inclusion #9

Open cmrd-senya opened 6 years ago

cmrd-senya commented 6 years ago

In this changeset I removed <div> from allowed tags as it makes it possible to post arbitrary <div> tags in journals with @<div>@ markup.

It was originally put there to avoid issue with <p> tag wrapping of included header/footer blocks by macros.

I found a workaround in current Textile parser which allows to disable wrapping of macros. This can be done by adding <code></code> in the beginning of the line. This way the rest of the line is rendered as is without being put in a paragraph.

This behavior may change in RedCloth4, but Redmine is still not there so we can use this workaround for a while, before Redmine comes up with an appropriate way to disable paragraphs.

fixes https://github.com/haru/redmine_wiki_extensions/issues/8 related https://code.google.com/archive/p/redminewikiext/issues/4 related https://redmine.org/issues/29588 related https://redmine.org/issues/13695

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.05%) to 86.902% when pulling 2e4df4438daf2b7aec01f4ea4aa564682b5ea6bd on cmrd-senya:use-div-macros-for-header-and-footer into c7a9c407cb3150e65bcd60b9630108f2d9269b85 on haru:develop.