search

haruaki07 / phosphor-svelte

A clean and friendly icon family for Svelte
MIT License
120 stars 7 forks source link

Type Definition causes issues with Module Resolution NodeNext #15

Closed OfficialCRUGG closed 2 months ago

OfficialCRUGG commented 6 months ago

While using the icon components itself works, VSCode shows an error when trying to use any of the components when moduleResolution is set to NodeNext in the tsconfig: image

According to a Svelte Maintainer, this is caused by the usage of ./shared instead of ./shared.js in the type definitions: image

OfficialCRUGG commented 6 months ago

It's important to note that this might need additional testing. As far as I know, this shouldn't break anything though.

OfficialCRUGG commented 3 months ago

Any update on this? The issue still persists, and on my end, the PR I submitted solves this.

haruaki07 commented 3 months ago

Any update on this? The issue still persists, and on my end, the PR I submitted solves this.

Please review the suggested changes on the PR. I apologize for the delay. I mistakenly forgot to mark it as suggest changes, so it remained in a pending state.