search

haruaki07 / phosphor-svelte

A clean and friendly icon family for Svelte
MIT License
136 stars 6 forks source link

Full Svelte 5 support #26

Open akkie opened 1 month ago

akkie commented 1 month ago

Hi,

I have seen that you have added support for Svelte 5 with #25. But this isn't enough, because the lib uses SvelteComponent under the hood for the declaration of an icon. But this type is deprecated in favour of the new Component type: https://svelte-5-preview.vercel.app/docs/breaking-changes#components-are-no-longer-classes-component-typing-changes

So it's currently not possible to pass icon components around, without a TypeScript error, when using Svelte 5 because of the incompatible type. Sure it renders, but TypeScript shows an error.

haruaki07 commented 1 month ago

Thanks! I didn't read the Svelte 5 changelog. For Svelte 5 support, it would be a new major version, perhaps I can release it under the @next version for now. For future releases, icon updates should be considered minor.

Is that good? looking for advice.

akkie commented 1 month ago

Yes, a @next tagged version would be awesome.

aawnu commented 3 weeks ago

Any news here?

I was not prepared for all icons to be forced 1em 😂