IsFirst and IsLast properties on Allomorph class should be negated.

harunzafer / nuve

Natural Language Processing Library for Turkish in C#

MIT License

98 stars 15 forks source link

IsFirst and IsLast properties on Allomorph class should be negated. #74

Closed notanaverageman closed 4 years ago

notanaverageman commented 8 years ago

Currently IsFirst is same as HasPrevious, which means that the allmorph is not the first. Same issue exists for IsLast.

hrzafer commented 8 years ago

Yes, you are right. I wrote both methods for the sake of readability. I should have documented it. I'll either delete the IsFirst and IsLast properties or document the situation. I'll also translate the method docs into English.