search

harvard-acc / ALADDIN

A pre-RTL, power-performance model for fixed-function accelerators
Other
170 stars 55 forks source link

Fix insertion to inflight_dma_nodes #41

Closed Sacusa closed 3 years ago

Sacusa commented 3 years ago

When the queue inflight_dma_nodes is full and more than maxInflightNodes new DMA nodes are executed, the new requests will wait indefinitely since the condition inflight_dma_nodes.size() < maxInflightNodes will never evaluate to true.

This commit changes the logic so that new nodes are only queued when inflight_dma_nodes has space.

Sacusa commented 3 years ago

I suppose this can be merged now?

yaoyuannnn commented 3 years ago

I suppose this can be merged now?

Go ahead and merge. We always leave it to the author to merge after getting approval :)