aladdin: Fix parsing of completely partitioned array entries.

harvard-acc / ALADDIN

A pre-RTL, power-performance model for fixed-function accelerators

Other

161 stars 54 forks source link

aladdin: Fix parsing of completely partitioned array entries. #44

Closed xyzsam closed 2 years ago

xyzsam commented 2 years ago

While parsing these entries, we skipped the wordsize parameter.

yaoyuannnn commented 2 years ago

I thought "complete" means the array would be implemented as a register and so that the word size wasn't needed?

xyzsam commented 2 years ago

A register file still has some number of entries, so a wordsize is still logically required. We probably got away with this because we'd just directly read the data out of the trace rather than in the simulator's data structures (unlike scratchpads).

xyzsam commented 2 years ago

Also, I'd just add that even if this doesn't change anything logically, it's still a bug that a parameter we normally expect to parse was unparsed - that could lead to hard to track down bugs in DDDG (which is already quite a mess of global variables....).

yaoyuannnn commented 2 years ago

Agreed. Thanks Sam!