search

harvard-acc / smaug

SMAUG: Simulating Machine Learning Applications Using Gem5-Aladdin
https://harvard-acc.github.io/smaug_docs
BSD 3-Clause "New" or "Revised" License
96 stars 27 forks source link

core: Remove the AllCache memory policy. #105

Closed xyzsam closed 2 years ago

xyzsam commented 2 years ago

AllCache as a memory policy doesn't make sense. A MemoryPolicy specifies how the data is moved, not where it gets stored after it is moved. The latter is specified in the Aladdin config files (scratchpads or caches). This option, when used, causes simulations to fail because the logic to handle this case was not added for HybridDatapath::handleCacheMemoryOp; however, in practice it is almost the same as using ACP, which does handle it. So, we just drop this policy as an option altogether.

Fixes issue #102.

yaoyuannnn commented 2 years ago

I think I kinda understand what the problem was. When this AllCache policy is used, we get the data from caches and want to store it to a local scratchpad, and it failed because gem5-aladdin's cache op handling doesn't support this (i.e. storing the data to a scratchpad).

xyzsam commented 2 years ago

Yup that's exactly the problem.