harvard-edge / cs249r_book

Collaborative book Machine Learning Systems
https://harvard-edge.github.io/cs249r_book/
Other
197 stars 83 forks source link

Possibility of a bug in the update_contributors.py #168

Open Naeemkh opened 2 months ago

Naeemkh commented 2 months ago

It appears that for some users, although the contributors' full names are being collected correctly, the contributors list is using the username instead of the full name.

profvjreddi commented 2 months ago

Hmm. Yea, @uchendui knows this best so will defer to him.

uchendui commented 2 months ago

Thanks for catching this @Naeemkh. Could you please point me to an example for reference?

Naeemkh commented 2 months ago

Thanks, @uchendui.

For example, in my case, here is the response for API request:

{
  "login": "Naeemkh",
  "id": 6773835,
  "node_id": "MDQ6VXNlcjY3NzM4MzU=",
  "avatar_url": "https://avatars.githubusercontent.com/u/6773835?v=4",
  "gravatar_id": "",
  "url": "https://api.github.com/users/Naeemkh",
  "html_url": "https://github.com/Naeemkh",
  "followers_url": "https://api.github.com/users/Naeemkh/followers",
  "following_url": "https://api.github.com/users/Naeemkh/following{/other_user}",
  "gists_url": "https://api.github.com/users/Naeemkh/gists{/gist_id}",
  "starred_url": "https://api.github.com/users/Naeemkh/starred{/owner}{/repo}",
  "subscriptions_url": "https://api.github.com/users/Naeemkh/subscriptions",
  "organizations_url": "https://api.github.com/users/Naeemkh/orgs",
  "repos_url": "https://api.github.com/users/Naeemkh/repos",
  "events_url": "https://api.github.com/users/Naeemkh/events{/privacy}",
  "received_events_url": "https://api.github.com/users/Naeemkh/received_events",
  "type": "User",
  "site_admin": false,
  "name": "Naeem Khoshnevis",
  "company": "Harvard University",
  "blog": "",
  "location": "USA, MA, Cambridge",
  "email": null,
  "hireable": true,
  "bio": "Senior Research Software Engineer\r\n    \r\n\r\n",
  "twitter_username": null,
  "public_repos": 25,
  "public_gists": 3,
  "followers": 23,
  "following": 91,
  "created_at": "2014-02-24T17:24:35Z",
  "updated_at": "2024-02-26T13:30:31Z"
}

As you can see, the name field is given ("name": "Naeem Khoshnevis"), however, the code eventually uses my username which is "login": "Naeemkh".