search

harvard-edge / cs249r_book

Introduction to Machine Learning Systems
https://harvard-edge.github.io/cs249r_book/
Other
1.2k stars 156 forks source link

Bad rendering for some links #474

Closed BravoBaldo closed 3 weeks ago

BravoBaldo commented 1 month ago

Please note in the "Index.qmd", under "Book Conventions", you have "Conventions", but in rendered "Index.html" you have a reference to "./contents/conventions.qmd" instead of "./contents/conventions.html"

The link under "Contributors": "[here](./contents/contributors.qmd)" is rendered correctly!

(Seen on my local version and to public version: https://mlsysbook.ai/)

Maybe you have to explicitly insert "conventions.qmd" into "_quarto.yml" !

PS: Please Note, internal links still refer to .qmd files!

BravoBaldo commented 1 month ago

I think you have to change all similar patterns (for example "here") with "@SomeReference".

Unfortunately, in this example, the title is declared as "{.unnumbered}"... see https://forum.posit.co/t/quarto-how-to-cross-reference-unnumbered-book-chapter/136279

profvjreddi commented 1 month ago

Hi! Thanks, @BravoBaldo, for the feedback and updates and for pointing out these issues. I have a big deadline tomorrow, so I'm planning to address this early next week. Stay tuned.