search

harvard-library / aspace-import-excel

Import resources, archival objects, etc. into ArchivesSpace using Excel spreadsheet files
Apache License 2.0
43 stars 10 forks source link

Fix for missing interpolation argument :msg #23

Closed wezzybytes closed 6 years ago

wezzybytes commented 6 years ago

I saw missing interpolation argument error when an import job failed.

Error: Processing stopped at row 4 [Some system error has occurred [missing interpolation argument :msg in "Processing stopped at row %{row} [%{msg}]" ({row=>4} given].]

Solution: Added a second parameter :msg => se.message to I18n.t() method call.

bobbi-SMR commented 6 years ago

Thanks for the fix! I got it in just before announcing my new! improved! plugin :-)

wezzybytes commented 6 years ago

Thanks! Looking forward to the new plugin. This plugin has saved us countless hours! We also made a few changes to Agent and Subject fields. Ended up modifying logic in ResourcesUpdatesController::process_subjects and ResourcesUpdatesController::process_agents methods.

bobbi-SMR commented 6 years ago

I'd be interested in seeing your changes (and the rationale for them) to the Agents & Subjects. I think we're a little behind in the A&S stuff -- most of our EADs only have them associated at the Resource level.

Cheers, Bobbi