search

harvard-library / aspace-import-excel

Import resources, archival objects, etc. into ArchivesSpace using Excel spreadsheet files
Apache License 2.0
43 stars 10 forks source link

Inconsistency with interpolation arguments in no_subject and no_agent error messages. #31

Closed wezzybytes closed 6 years ago

wezzybytes commented 6 years ago

I found that num argument was being used inconsistently. I fixed it by including num in both no_subject and no_agent error messages.

In SubjectHandler.create_subj, num was being passed to I18n.t method, but it wasn't defined in that method. Fixed it by passing num to create_subj method.

bobbi-SMR commented 6 years ago

You've made so many improvements, I'd like to add you as a contributor on the Readme; if that's all right, (and also if I can include your Real Name), send me email at bobbi_foxATharvard.edu.