harvard-lil / h2o

H2O is a web app for creating and reading open educational resources, primarily in the legal field
https://opencasebook.org
GNU Affero General Public License v3.0
36 stars 30 forks source link

Handle when some legal doc metadata fields might be present but None #1837

Closed lizadaly closed 1 year ago

lizadaly commented 1 year ago

fixes #1836

I tested this locally using the same casebook that Sentry flagged (it was just a bot crawling the site so it was deep on page 10 of an older casebook).

I assume it was the middle item here:

image
codecov-commenter commented 1 year ago

Codecov Report

Merging #1837 (af0c668) into develop (db0b32f) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #1837   +/-   ##
========================================
  Coverage    76.96%   76.96%           
========================================
  Files           50       50           
  Lines         6563     6565    +2     
========================================
+ Hits          5051     5053    +2     
  Misses        1512     1512           
Impacted Files Coverage Δ
web/main/models.py 75.66% <100.00%> (+0.02%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.