Currently superusers will see three sources for legal documents: CAP, GPO, and "Legacy." The legacy type isn't exposed to non-admins already; this just puts admins on the same footing.
This will result in a small performance optimization for staff users doing searches—the front-end API is written such that it issues one distinct HTTP query for each source type, so are waiting for 3 HTTP responses to get results instead of 2 (one which is always empty of results).
In the related ticket I noted a test failure following this change, but I can't reproduce this now.
lizadaly
commented
1 year ago
Currently superusers will see three sources for legal documents: CAP, GPO, and "Legacy." The legacy type isn't exposed to non-admins already; this just puts admins on the same footing.
This will result in a small performance optimization for staff users doing searches—the front-end API is written such that it issues one distinct HTTP query for each source type, so are waiting for 3 HTTP responses to get results instead of 2 (one which is always empty of results).
In the related ticket I noted a test failure following this change, but I can't reproduce this now.