search

harvard-lil / h2o

H2O is a web app for creating and reading open educational resources, primarily in the legal field
https://opencasebook.org
GNU Affero General Public License v3.0
36 stars 30 forks source link

Move Quick Add results to bottom to match other search behavior #1955

Closed lizadaly closed 1 year ago

lizadaly commented 1 year ago

There was a deliberate design decision that legal document search results would appear below the search box on some pages, and above it in others. This is a bit confusing in practice though, so we've decided make the results appear below the search box in all cases. (There's a second occurrence of this but it's in #1953 which should just be deleted.)

This has an additional advantage in reducing visual page jank, as the search box stays in place now after clicking submit rather than bouncing below the viewport.

This also deletes two Vue props that had no effect (one seemed related to this positioning issue, but was unused).

Before

image

After

image
codecov-commenter commented 1 year ago

Codecov Report

Merging #1955 (a5db612) into develop (20e81f9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1955   +/-   ##
========================================
  Coverage    76.70%   76.70%           
========================================
  Files           60       60           
  Lines         6775     6775           
========================================
  Hits          5197     5197           
  Misses        1578     1578

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.