search

harvard-lil / h2o

H2O is a web app for creating and reading open educational resources, primarily in the legal field
https://opencasebook.org
GNU Affero General Public License v3.0
36 stars 30 forks source link

Vue unit test suite cannot be upgraded past 1.0.0-beta.29 #1962

Closed lizadaly closed 1 year ago

lizadaly commented 1 year ago

https://github.com/vuejs/vue-test-utils is pinned at a beta version from February, 2019. Upgrading to any of the 1.x release versions causes multiple test failures. (The 1.x line targets Vue 2 and is still actively maintained.)

Although test harnesses aren't user-facing, it's valuable to maintain and expand test coverage even for projects in maintenance mode—tests make it possible to safely iterate on software that is touched only occasionally, or with incomplete information.

The failing tests are mostly around whitespace handling—this is important for the annotation code, so it's good that there are tests for this, but it's possible that the tests rely on side effects of the beta test harness and should be rewritten.

leppert commented 1 year ago

Oh the days. I wrote most of this back in 2019. Happy to answer questions from what I can remember. I do recall the whitespace struggles but my recollection was that they had to do with Vue core's handling rather than the test harness, but who knows. It does seem telling that this doesn't involve updating Vue but rather just the test harness.

rebeccacremona commented 1 year ago

Oh the days.

image image image