harvard-lil / h2o

H2O is a web app for creating and reading open educational resources, primarily in the legal field
https://opencasebook.org
GNU Affero General Public License v3.0
35 stars 30 forks source link

Improve attribution and appearance of credits tab #2013

Closed lizadaly closed 1 year ago

lizadaly commented 1 year ago

fixes #2012

The Credits page on production has the following limitations:

In addition, the Credits view has some complex business logic but no tests.

This PR:

I'm sure there are still some edge cases here but I think this smooths over some of the most common flaws in the status quo.

Before

Casebooks with lots of contributors generated hugely long lists, and obscured individual contributions. Many of these links 404 or lead to login pages because they refer to now-private drafts.

imageimage

After

This shows the immediate parent casebook, plus an additional section below for earlier contributors that includes the top-level casebook or sections that were cloned:

image

If we explore the n-1 casebook, the immediate parent, now the two earlier contributors are foregrounded, and the specific resources are listed:

image
codecov-commenter commented 1 year ago

Codecov Report

Merging #2013 (87db581) into develop (50e51fc) will decrease coverage by 0.18%. The diff coverage is 95.58%.

@@             Coverage Diff             @@
##           develop    #2013      +/-   ##
===========================================
- Coverage    76.82%   76.65%   -0.18%     
===========================================
  Files           62       64       +2     
  Lines         6927     7026      +99     
===========================================
+ Hits          5322     5386      +64     
- Misses        1605     1640      +35     
Impacted Files Coverage Δ
web/main/models.py 82.76% <ø> (+8.82%) :arrow_up:
web/main/test/test_publishing.py 100.00% <ø> (ø)
web/main/urls.py 100.00% <ø> (ø)
web/main/views.py 71.88% <86.36%> (-0.17%) :arrow_down:
web/main/test/test_credits.py 100.00% <100.00%> (ø)
web/main/utils.py 76.43% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.