search

harvard-lil / h2o

H2O is a web app for creating and reading open educational resources, primarily in the legal field
https://opencasebook.org
GNU Affero General Public License v3.0
35 stars 30 forks source link

Restore playwright; upgrade black #2045

Closed bensteinberg closed 5 months ago

bensteinberg commented 5 months ago

This PR restores playwright to requirements.in, as we need it for functional tests; it also unpins and upgrades black and lets it make some changes.

https://github.com/psf/black/blob/main/CHANGES.md#2430

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.89%. Comparing base (ab56c04) to head (6ff3ac7).

Files Patch % Lines
web/main/legal_document_sources.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2045 +/- ## ======================================== Coverage 76.89% 76.89% ======================================== Files 60 60 Lines 6999 6999 ======================================== Hits 5382 5382 Misses 1617 1617 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bensteinberg commented 5 months ago

Hmmm, does this mean the functional tests aren't currently run by Github Actions? Interesting, I didn't realize that.

I think they are running!

rebeccacremona commented 5 months ago

I must be confused. If playwright is necessary for functional tests, and functional tests are run in Github Actions, and we removed playwright in an earlier PR... I would have expected to see the tests fail. Since we didn't... I'm confused.

bensteinberg commented 5 months ago

Could playwright be built in to the runner?